olaven
/
nrss
1
0
Fork 0
Code Issues 6 Pull Requests Packages Projects Releases Wiki Activity

Fix invalid feed characters #31

Merged
olaven merged 3 commits from fix-bad-feed-characters into main 2024-04-14 10:16:00 +00:00
Conversation 0 Commits 3 Files Changed 3 +24 -5
olaven commented 2024-04-14 10:13:18 +00:00 (Migrated from github.com)
Copy Link

This PR fixes a (sneaky) bug introduced in #25.
XML strings were stringified before being returned to the client, producing invalid XML ("'<></>'" over "<></>").
This PR changes the code such that only JSON responses are stringified.

This PR fixes a (sneaky) bug introduced in #25. XML strings were stringified before being returned to the client, producing invalid XML ("'<></>'" over "<></>"). This PR changes the code such that only JSON responses are stringified.
olaven (Migrated from github.com) reviewed 2024-04-14 10:14:01 +00:00
routes/api/feeds/[seriesId].ts
olaven (Migrated from github.com) commented 2024-04-14 10:13:54 +00:00
Copy Link
```suggestion ```
olaven (Migrated from github.com) commented 2024-04-14 10:13:59 +00:00
Copy Link
```suggestion ```
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: olaven/nrss#31
No description provided.
Delete Branch "fix-bad-feed-characters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?