feat: Add unit-tests #25

Merged

timharek merged 31 commits from feature-testing into main

2024-04-11 19:10:16 +00:00

timharek commented

2024-04-05 16:34:33 +00:00

(Migrated from github.com)

Currently work in progress.

Added tests for:
- caching.ts
- nrk.ts
- rss.ts (only one new test)
Fixed "bad" types in test-utils.ts.
Moved utils.ts to ./lib.
Added test task.
Added CI step for linting, formatting, type-checking and testing (via GitHub Actions).
Fixed filename path in generate-types.ts.
Added Response-function helpers for JSON and XML responses.
Improved type-safety for caching.ts.

Closes #18

Currently work in progress. - Added tests for: - `caching.ts` - `nrk.ts` - `rss.ts` (only one new test) - Fixed "bad" types in `test-utils.ts`. - Moved `utils.ts` to `./lib`. - Added test task. - Added CI step for linting, formatting, type-checking and testing (via GitHub Actions). - Fixed filename path in `generate-types.ts`. - Added `Response`-function helpers for JSON and XML responses. - Improved type-safety for `caching.ts`. Closes #18

olaven commented

2024-04-06 19:28:40 +00:00

(Migrated from github.com)

@timharek Great start! I'm attempting to decouple the RSS generation code as part of #23. I think I'll have a draft shortly. I'll leave the API code untouched, so this should not be impacted, but I thought I'd give a heads up regardless.

👍 1

timharek commented

2024-04-08 16:52:11 +00:00

(Migrated from github.com)

@olaven do you see any more tests that need to be added? 💭

olaven commented

2024-04-09 07:46:55 +00:00

(Migrated from github.com)

@olaven do you see any more tests that need to be added? 💭

No, this looks good! Assign me as reviewer whenever you feel ready, and I'll go through it thouroughly :)

> @olaven do you see any more tests that need to be added? 💭 No, this looks good! Assign me as reviewer whenever you feel ready, and I'll go through it thouroughly :)

timharek commented

2024-04-10 14:43:21 +00:00

(Migrated from github.com)

Assign me as reviewer whenever you feel ready

Not sure if you got notified, @olaven 😅

> Assign me as reviewer whenever you feel ready Not sure if you got notified, @olaven 😅

olaven commented

2024-04-11 08:12:07 +00:00

(Migrated from github.com)

Assign me as reviewer whenever you feel ready

Not sure if you got notified, @olaven 😅

I did, I've just been busy! But thank you for reminding me regardless :) Will hopefully have a look this evening.

> > Assign me as reviewer whenever you feel ready > > Not sure if you got notified, @olaven 😅 I did, I've just been busy! But thank you for reminding me regardless :) Will hopefully have a look this evening.

olaven (Migrated from github.com) approved these changes 2024-04-11 19:10:09 +00:00