From bcf648f64eefaa891398307cd2fc2d71cc32d2db Mon Sep 17 00:00:00 2001 From: olaven Date: Thu, 16 Mar 2023 10:02:18 +0100 Subject: [PATCH 1/5] Adding itumes:category and itunes:owner --- routes/api/feeds/[seriesId].ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/routes/api/feeds/[seriesId].ts b/routes/api/feeds/[seriesId].ts index 963092b..7269c33 100644 --- a/routes/api/feeds/[seriesId].ts +++ b/routes/api/feeds/[seriesId].ts @@ -39,6 +39,13 @@ async function buildFeed(seriesId: string) { tag("title", serie.titles.title), tag("link", linkValue), tag("itunes:author", "NRK"), + tag("itunes:category", "", [["text", serie.category.id]]), + tag("itunes:owner", + [ + tag("itunes:name", "NRK"), + tag("itunes:email", "nrkpodcast@nrk.no") + ] + ), tag( "description", serie.titles.subtitle || "" -- 2.40.1 From 0198c37a063281087b8c2a5519c75053f2ce3c9c Mon Sep 17 00:00:00 2001 From: olaven Date: Thu, 16 Mar 2023 10:10:51 +0100 Subject: [PATCH 2/5] Static category -> Government --- routes/api/feeds/[seriesId].ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/routes/api/feeds/[seriesId].ts b/routes/api/feeds/[seriesId].ts index 7269c33..e258981 100644 --- a/routes/api/feeds/[seriesId].ts +++ b/routes/api/feeds/[seriesId].ts @@ -39,7 +39,12 @@ async function buildFeed(seriesId: string) { tag("title", serie.titles.title), tag("link", linkValue), tag("itunes:author", "NRK"), - tag("itunes:category", "", [["text", serie.category.id]]), + /* serie.category.id does not overlap with Apple's supported categories.. + These podcast feeds are not going to be indexed in itunes anyways, so + a static, valid category is fine. The point is simply to pass third party + podcast feed validation. + */ + tag("itunes:category", "", [["text", "Government"]]), tag("itunes:owner", [ tag("itunes:name", "NRK"), -- 2.40.1 From f6c77692f40cee7bff98f34227e28aa0740045b8 Mon Sep 17 00:00:00 2001 From: olaven Date: Thu, 16 Mar 2023 17:57:34 +0100 Subject: [PATCH 3/5] Episode link leads to webpage, not mp3 file --- routes/api/feeds/[seriesId].ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routes/api/feeds/[seriesId].ts b/routes/api/feeds/[seriesId].ts index e258981..3772feb 100644 --- a/routes/api/feeds/[seriesId].ts +++ b/routes/api/feeds/[seriesId].ts @@ -7,7 +7,7 @@ function toItemTag(episode: Episode) { const description = episode.titles.subtitle || ""; return tag("item", [ tag("title", episode.titles.title), - tag("link", episode.url), + tag("link", episode._links.share.href), tag("description", description), tag("itunes:summary", description), tag("guid", episode.id, [["isPermaLink", "false"]]), -- 2.40.1 From b1bd5fabcc3dec1456479b87a7ff870e8dbd9393 Mon Sep 17 00:00:00 2001 From: olaven Date: Thu, 16 Mar 2023 18:00:28 +0100 Subject: [PATCH 4/5] Stupid change to retrigger deploy --- routes/api/feeds/[seriesId].ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routes/api/feeds/[seriesId].ts b/routes/api/feeds/[seriesId].ts index 3772feb..7caf5fc 100644 --- a/routes/api/feeds/[seriesId].ts +++ b/routes/api/feeds/[seriesId].ts @@ -39,7 +39,7 @@ async function buildFeed(seriesId: string) { tag("title", serie.titles.title), tag("link", linkValue), tag("itunes:author", "NRK"), - /* serie.category.id does not overlap with Apple's supported categories.. + /* serie.category.id does not overlap with Apple's supported categories... These podcast feeds are not going to be indexed in itunes anyways, so a static, valid category is fine. The point is simply to pass third party podcast feed validation. -- 2.40.1 From 5ded2821cbb855a92103033833709c2437dce8fd Mon Sep 17 00:00:00 2001 From: olaven Date: Thu, 16 Mar 2023 18:08:14 +0100 Subject: [PATCH 5/5] Retry deploy --- routes/api/feeds/[seriesId].ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routes/api/feeds/[seriesId].ts b/routes/api/feeds/[seriesId].ts index 7caf5fc..3772feb 100644 --- a/routes/api/feeds/[seriesId].ts +++ b/routes/api/feeds/[seriesId].ts @@ -39,7 +39,7 @@ async function buildFeed(seriesId: string) { tag("title", serie.titles.title), tag("link", linkValue), tag("itunes:author", "NRK"), - /* serie.category.id does not overlap with Apple's supported categories... + /* serie.category.id does not overlap with Apple's supported categories.. These podcast feeds are not going to be indexed in itunes anyways, so a static, valid category is fine. The point is simply to pass third party podcast feed validation. -- 2.40.1