Mfa bugs #38
|
|
@ -30,7 +30,12 @@ export const DonationSection = function () {
|
|||
</p>
|
||||
|
||||
<div className="justify-center my-8">
|
||||
<form className={"flex flex-col mx-4"}>
|
||||
<form
|
||||
className={"flex flex-col mx-4"}
|
||||
onSubmit={(e) => {
|
||||
e.preventDefault();
|
||||
}}
|
||||
>
|
||||
<Input
|
||||
type={"email"}
|
||||
placeholder={"din@epost.no"}
|
||||
|
|
|
|||
|
|
@ -2,8 +2,10 @@ import { nrkRadio } from "./nrk/nrk.ts";
|
|||
import { Series, storage } from "./storage.ts";
|
||||
import * as datetime from "$std/datetime/mod.ts";
|
||||
import { Episode } from "./storage.ts";
|
||||
import { Buffer } from "node:buffer";
|
||||
|
||||
const SYNC_INTERVAL_HOURS = 1;
|
||||
const DENO_KV_MAX_BYTES = 65_536;
|
||||
|
||||
async function initialFetch(options: { id: string }): Promise<Series | null> {
|
||||
const series = await nrkRadio.getSeries(options.id);
|
||||
|
|
@ -23,6 +25,7 @@ type UpdatedSeries = {
|
|||
lastFetch: Date;
|
||||
episodes: Episode[];
|
||||
} & Series;
|
||||
|
||||
async function updateFetch(existingSeries: Series): Promise<UpdatedSeries | Series | null> {
|
||||
const series = await nrkRadio.getSeries(existingSeries.id);
|
||||
if (!series) {
|
||||
|
|
@ -44,19 +47,44 @@ async function updateFetch(existingSeries: Series): Promise<UpdatedSeries | Seri
|
|||
const episodesSortedDescending = [...newEpisodes, ...existingSeries.episodes]
|
||||
.sort((a, b) => a.date.getTime() > b.date.getTime() ? -1 : 1);
|
||||
|
||||
const updated = {
|
||||
const withNewEpisodes = {
|
||||
...existingSeries,
|
||||
lastFetch: new Date(),
|
||||
episodes: episodesSortedDescending,
|
||||
};
|
||||
|
||||
const updateSuccessful = await storage.writeSeries(updated);
|
||||
/**
|
||||
* The KV store has a limit of 64kb per value.
|
||||
* A pragmatic (not perfect) solution is to trim the series
|
||||
* down until we're within the limit.
|
||||
*
|
||||
* Other ideas for the future:
|
||||
* - splitting the series into multiple keys
|
||||
* - using a different storage solution
|
||||
*/
|
||||
const trimmed = trimSeriesToSize(withNewEpisodes, DENO_KV_MAX_BYTES);
|
||||
|
||||
const updateSuccessful = await storage.writeSeries(trimmed);
|
||||
if (!updateSuccessful) {
|
||||
console.log(`Failed to update series ${existingSeries.id}`);
|
||||
return null;
|
||||
}
|
||||
|
||||
return updated;
|
||||
return trimmed;
|
||||
}
|
||||
|
||||
function trimSeriesToSize(series: Series, bytes: number): Series {
|
||||
const currentBytes = Buffer.byteLength(JSON.stringify(series));
|
||||
if (currentBytes <= bytes) {
|
||||
return series;
|
||||
}
|
||||
|
||||
const trimmed = {
|
||||
...series,
|
||||
episodes: series.episodes.slice(0, -1),
|
||||
};
|
||||
|
||||
return trimSeriesToSize(trimmed, bytes);
|
||||
}
|
||||
|
||||
function getTimeSinceLastFetch(inputDate: Date, againstDate = new Date()): number | null {
|
||||
|
|
|
|||
|
|
@ -6,10 +6,8 @@ export function getHostUrl() {
|
|||
if (deploymentId) {
|
||||
return `https://nrss-${deploymentId}.deno.dev`;
|
||||
} else if (tunnelUrl) {
|
||||
console.debug(`Using tunnel URL: ${tunnelUrl}`);
|
||||
return tunnelUrl;
|
||||
} else {
|
||||
console.debug(`Assuming localhost`);
|
||||
return "http://localhost:8000";
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,5 +1,6 @@
|
|||
// deno-lint-ignore-file ban-ts-comment
|
||||
import "jsr:@std/dotenv/load";
|
||||
import { encodeHex } from "jsr:@std/encoding/hex";
|
||||
import { getHostUrl } from "../utils.ts";
|
||||
import { STATUS_CODE } from "$fresh/server.ts";
|
||||
|
||||
|
|
@ -50,7 +51,8 @@ export const createAgreement = async function (email: string) {
|
|||
// @ts-ignore
|
||||
headers: {
|
||||
authorization: `Bearer ${token}`,
|
||||
"Idempotency-Key": `${email}-${Date.now()}`,
|
||||
// anonymized and trimmed to not be too long (then it fails)
|
||||
"Idempotency-Key": `${encodeHex(email).slice(0, 10)}-${Date.now()}`,
|
||||
...standardVippsHeaders,
|
||||
},
|
||||
body: JSON.stringify({
|
||||
|
|
|
|||
|
|
@ -0,0 +1,13 @@
|
|||
# Bugs
|
||||
|
||||
- [ ] enter on sponsor input reloads the page
|
||||
- [x] reproduce
|
||||
- [x] fix
|
||||
- [ ] report back to user (MFA email)
|
||||
- [ ] user (MFA email) gets an error with one of his emails (see mail thread)
|
||||
- [x] reproduce
|
||||
- [x] fix
|
||||
- [ ] report back to user
|
||||
- [ ] there are more users registered as paying users than there are payments received
|
||||
- [ ] are these people supposed to still be subscribers?
|
||||
- [ ] how can this have happenned?
|
||||
Loading…
Reference in New Issue