olaven
/
nrss
1
0
Fork 0
Code Issues 6 Pull Requests Packages Projects Releases Wiki Activity

Compare commits

merge into: olaven:main
Branches Tags
olaven:main
olaven:workaround-broken-cache-api
olaven:remove-first-promotion
olaven:cache-responses
olaven:allow-sub-addresses-in-emails
olaven:fix-vipps-crash
olaven:revert-41-fix-vipps-crash
olaven:add-another-promotional-text
...
pull from: olaven:revert-41-fix-vipps-crash
Branches Tags
olaven:main
olaven:workaround-broken-cache-api
olaven:remove-first-promotion
olaven:cache-responses
olaven:allow-sub-addresses-in-emails
olaven:fix-vipps-crash
olaven:revert-41-fix-vipps-crash
olaven:add-another-promotional-text

4 Commits
main ... revert-41-

Author SHA1 Message Date
Olav Sundfør 89ad059938
Revert "FIX: Existing agreement exists, but is out of sync (#41)" 
This reverts commit 43477f0798.
 2025-05-26 14:32:32 +02:00
Olav Sundfør 43477f0798
FIX: Existing agreement exists, but is out of sync (#41) 2025-05-26 14:31:55 +02:00
olaven 2109ae438f deno formatting 2025-04-30 16:18:05 +02:00
olaven 0ce01b97f1 Add a second promo text to the front. 
NRSS does not have enough supporters to break even and thus costs me
quite a bit every month. However, it seems to have a stable and high
user base, most of whom presumably could pay. As earlier, I'd like to
avoid shoving the service behind a paywall - that feels totally wrong
for what this project is supposed to be. This PR introduces another,
shorter link to donations _before_ the episode description in the
hopes of attracting more paid users. Let's see if it works :)

The last time there was a promo text at the start of the description,
@augustskare correctly pointed out that this hides the original description
from many views in podcast players in #34. That's not nice. I've tried to
acommodate this by making the initial description much shorter than
the one I had then (which now comes at the end).
 2025-04-30 16:16:33 +02:00
2 changed files with 22 additions and 15 deletions
Show Stats Expand all files Collapse all files

18
lib/rss.test.ts
View File

@ -1,4 +1,4 @@
import { assertEquals, assertExists } from "$std/assert/mod.ts";
import { assertEquals, assertExists, assertLess } from "$std/assert/mod.ts";
import { testUtils } from "./test-utils.ts";
import { rss } from "./rss.ts";
import { forTestingOnly } from "./rss.ts";
@ -30,6 +30,20 @@ Deno.test("generated rss contains promo with link to donations page", () => {
const series = testUtils.generateSeries();
const feed = rss.assembleFeed(series);
console.log(feed);
feed.includes("Vurder å støtte utviklingen via Vipps");
});
Deno.test("generated rss contains promo with link to donations page", () => {
const series = testUtils.generateSeries();
const feed = rss.assembleFeed(series);
const indexOfFirstPromotion = feed.indexOf(
"NRSS er avhengig av din Vipps-støtte",
);
const indexOfSecondPromotion = feed.indexOf("Vurder å støtte utviklingen");
assertLess(
indexOfFirstPromotion,
indexOfSecondPromotion,
"First promotion should come before the second",
);
});

19
lib/rss.ts
View File

@ -27,16 +27,11 @@ function assembleFeed(series: Series): string {
tag("itunes:name", "NRK"),
tag("itunes:email", "nrkpodcast@nrk.no"),
]),
tag(
"description",
series.subtitle || "",
),
tag("description", series.subtitle || ""),
tag("ttl", "60"), //60 minutes
...(series.imageUrl
? [
tag("itunes:image", "", [
["href", series.imageUrl],
]),
tag("itunes:image", "", [["href", series.imageUrl]]),
tag("image", [
tag("url", series.imageUrl),
tag("title", series.title),
@ -58,10 +53,11 @@ function assembleFeed(series: Series): string {
}
function descriptionWithDonationPromotion(description: string): string {
const promotion =
const firstPromotion = `⬇️NRSS er avhengig av din Vipps-støtte⬇️`;
const secondPromotion =
`Takk for at du bruker NRSS 🙏🌟 Vurder å støtte utviklingen via Vipps med omtrent det samme som prisen på en kaffekopp. Se mer på https://nrss.deno.dev/`;
return `${description}\n\n${promotion}`;
return `${firstPromotion}\n\n${description}\n\n${secondPromotion}`;
}
function assembleEpisode(episode: Episode, seriesId: Series["id"]): Tag {
@ -76,10 +72,7 @@ function assembleEpisode(episode: Episode, seriesId: Series["id"]): Tag {
tag("pubDate", new Date(episode.date).toUTCString()),
tag("itunes:duration", episode.durationInSeconds.toString()),
tag("podcast:chapters", "", [
[
"url",
`${getHostUrl()}/api/feeds/${seriesId}/${episode.id}/chapters`,
],
["url", `${getHostUrl()}/api/feeds/${seriesId}/${episode.id}/chapters`],
["type", "application/json+chapters"],
]),
tag("enclosure", "", [