From d3a4c4a5853c44bfe405229d5a411dd68090a3f3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Olav=20Sundf=C3=B8r?= <olav@sundfoer.com>
Date: Mon, 23 Sep 2024 17:44:16 +0200
Subject: [PATCH] Mfa bugs (#38)

---
 islands/DonationSection.tsx |  7 ++++++-
 lib/vipps/vipps.ts          |  4 +++-
 todo.md                     | 13 +++++++++++++
 3 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 todo.md

diff --git a/islands/DonationSection.tsx b/islands/DonationSection.tsx
index 84dec1d..3f98708 100644
--- a/islands/DonationSection.tsx
+++ b/islands/DonationSection.tsx
@@ -30,7 +30,12 @@ export const DonationSection = function () {
         </p>
 
         <div className="justify-center my-8">
-          <form className={"flex flex-col mx-4"}>
+          <form
+            className={"flex flex-col mx-4"}
+            onSubmit={(e) => {
+              e.preventDefault();
+            }}
+          >
             <Input
               type={"email"}
               placeholder={"din@epost.no"}
diff --git a/lib/vipps/vipps.ts b/lib/vipps/vipps.ts
index 47715a6..33cdeb3 100644
--- a/lib/vipps/vipps.ts
+++ b/lib/vipps/vipps.ts
@@ -1,5 +1,6 @@
 // deno-lint-ignore-file ban-ts-comment
 import "jsr:@std/dotenv/load";
+import { encodeHex } from "jsr:@std/encoding/hex";
 import { getHostUrl } from "../utils.ts";
 import { STATUS_CODE } from "$fresh/server.ts";
 
@@ -50,7 +51,8 @@ export const createAgreement = async function (email: string) {
     // @ts-ignore
     headers: {
       authorization: `Bearer ${token}`,
-      "Idempotency-Key": `${email}-${Date.now()}`,
+      // anonymized and trimmed to not be too long (then it fails)
+      "Idempotency-Key": `${encodeHex(email).slice(0, 10)}-${Date.now()}`,
       ...standardVippsHeaders,
     },
     body: JSON.stringify({
diff --git a/todo.md b/todo.md
new file mode 100644
index 0000000..852bf6b
--- /dev/null
+++ b/todo.md
@@ -0,0 +1,13 @@
+# Bugs
+
+- [ ] enter on sponsor input reloads the page
+  - [x] reproduce
+  - [x] fix
+  - [ ] report back to user (MFA email)
+- [ ] user (MFA email) gets an error with one of his emails (see mail thread)
+  - [x] reproduce
+  - [x] fix
+  - [ ] report back to user
+- [ ] there are more users registered as paying users than there are payments received
+  - [ ] are these people supposed to still be subscribers?
+  - [ ] how can this have happenned?