From a5db00c82401fd06be25121d95f8e1ab512bd66a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20H=C3=A5rek=20Andreassen?= <tim@harek.no>
Date: Sat, 30 Mar 2024 11:52:55 +0100
Subject: [PATCH] refactor: Use early returns instead of if-else
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
---
 lib/nrk.ts | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/lib/nrk.ts b/lib/nrk.ts
index c0e121c..4a3eb1f 100644
--- a/lib/nrk.ts
+++ b/lib/nrk.ts
@@ -48,9 +48,8 @@ export const nrkRadio = {
     >(`https://psapi.nrk.no/radio/search/search?q=${query}`);
     if (status === OK && response) {
       return response.results.series?.results;
-    } else {
-      throw `Something went wrong with ${query} - got status ${status}`;
     }
+    throw `Something went wrong with ${query} - got status ${status}`;
   },
   getSerieData: async (seriesId: string) => {
     const [
@@ -76,17 +75,15 @@ export const nrkRadio = {
         ...serieResponse.series,
         episodes,
       };
-    } else {
-      throw `Error getting episodes for ${seriesId}: EpisodeStatus: ${episodeStatus}. SerieStatus: ${seriesStatus}`;
     }
+    throw `Error getting episodes for ${seriesId}: EpisodeStatus: ${episodeStatus}. SerieStatus: ${seriesStatus}`;
   },
   getEpisode: async (seriesId: string, episodeId: string): Promise<OriginalEpisode | null> => {
     const url = `https://psapi.nrk.no/radio/catalog/podcast/${seriesId}/episodes/${episodeId}`;
     const [status, episode] = await get<OriginalEpisode>(url);
-    if (status !== OK) {
-      throw `Error getting episode ${episodeId}. Status: ${status}. Series: ${seriesId}`;
+    if (status === OK && episode) {
+      return episode;
     }
-
-    return episode;
+    throw `Error getting episode ${episodeId}. Status: ${status}. Series: ${seriesId}`;
   },
 };