From a40830cebbfed81245e3e9070eafc0c13ee50022 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20H=C3=A5rek=20Andreassen?= <tim@harek.no>
Date: Mon, 8 Apr 2024 17:21:00 +0200
Subject: [PATCH] refactor: Use early return
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Tim Hårek Andreassen <tim@harek.no>
---
 lib/caching.ts | 3 ++-
 lib/nrk/nrk.ts | 9 +++++----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/lib/caching.ts b/lib/caching.ts
index 93766ea..293c054 100644
--- a/lib/caching.ts
+++ b/lib/caching.ts
@@ -48,7 +48,8 @@ async function updateFetch(existingSeries: Series): Promise<UpdatedSeries | null
 
   const updateSuccessful = await storage.write(updated);
   if (!updateSuccessful) {
-    throw new Error(`Failed to update series ${existingSeries.id}`);
+    console.log(`Failed to update series ${existingSeries.id}`);
+    return null;
   }
 
   return updated;
diff --git a/lib/nrk/nrk.ts b/lib/nrk/nrk.ts
index 8fc9b77..785f959 100644
--- a/lib/nrk/nrk.ts
+++ b/lib/nrk/nrk.ts
@@ -146,11 +146,12 @@ async function getEpisodeWithDownloadLink(
     playbackResponse = body;
   }
 
-  if (playbackStatus === STATUS_CODE.OK && playbackResponse) {
-    return { ...episode, url: playbackResponse.playable.assets[0].url };
-  } else {
-    throw `Error getting downloadLink for ${episode.episodeId}, serie: ${episode.originalTitle}. Status: ${playbackStatus}`;
+  if (playbackStatus !== STATUS_CODE.OK && !playbackResponse) {
+    throw new Error(
+      `Error getting downloadLink for ${episode.episodeId}, serie: ${episode.originalTitle}. Status: ${playbackStatus}`,
+    );
   }
+  return { ...episode, url: playbackResponse.playable.assets[0].url };
 }
 
 export const nrkRadio = {